feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(wallet-integration): implement server and API * feat(wallet-integration): add a few tests to server. Needs more * refactor(wallet-integration): just use call_data, remove data types * feat(wallet-integration): add frontend type for flexible serving * feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method * refactor(wallet-integration): move to module with pop-cli crate * feat(wallet-integration): server-side error handling, update port to 9090 * refactor(wallet-integration): restructure server for easier use in thread * fix(wallet-integration): remove invalid fn `finish` * docs(wallet-integration): inline comments * test(wallet-integration): unit tests for wallet-integration server. Add new frontend type * feat(wallet-integration): two new routes: error and terminate * refactor(wallet-integration): consistent comments, remove unnecessary code in tests * feat: add TransactionData::new * refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests * chore: clippy warning
…ntegration -- PoC
…ntegration -- PoC
…error, cors, and other misc. improvements
peterwht
changed the base branch from
peter/feat-wallet-integration
to
peter/feat-wallet-integration-up-contract
AlexD10S
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Changes look good.
Probably frontend feedback better here than in the frontend repository:
The flow looks great, nice work! It would be even better with the frontend a bit more polished.
My main feedback is about the buttons: Terminate appears bigger than Sign, which can be confusing. I suggest either moving Terminate below as a text-only button or emphasizing Sign as the primary button to make its importance clearer.
I know you're already aware, but just to have it written down so we don't forget: the dry_run functionality still needs to be implemented.
peterwht
force-pushed
the
peter/feat-wallet-integration-up-contract
branch
from
01e9a30 to
2a09b0a
Compare
|
superseded by #380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frontend from: https://github.com/r0gue-io/wallet-signing-portal
based on: #365