-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable pop up without project type specification #403
base: main
Are you sure you want to change the base?
Conversation
19e4961
to
3bc239f
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #403 +/- ##
==========================================
+ Coverage 75.11% 75.30% +0.18%
==========================================
Files 63 64 +1
Lines 13842 13927 +85
Branches 13842 13927 +85
==========================================
+ Hits 10398 10488 +90
+ Misses 2118 2095 -23
- Partials 1326 1344 +18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks great! I left some comments mainly for the code improvement. Some based on my personal preferences. Not a blocker though.
Enables
pop up
command to run without specifying contract or parachain, automatically detecting the project type.Handles the deprecation of
pop up contract
andpop up parachain
, keeping them functional for now but marking them for future removal (Reference feat: enable building without project type specification #222).Refactors
pop up
to distinguish between deploying a parachain and launching a local network.pop up parachain
is now migrated topop up network
.pop up
in a parachain template will deploy a parachain instead of launching a network.Note:: Currently, running
pop up
inside a parachain project does nothing. The deployment logic for parachains has been removed in this commit 38a19a8 and will be implemented separately in an upcoming PR feat: deploy parachain #404.Commands for testing
[sc-2506]