Do not depend on generated classes for update-secret extension #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some CI testing jobs are using the 3.7 branch of codegen, which does not contain the update-secret extension. The Java client then cannot be built because it requires some generated code for the extension. This commit adds the code to handle update-secret and thus makes the generated code not necessary. This is just a workaround for these testing jobs to succeed, it does not change the handling of the update-secret extension in the client. [#167029587] References #626
michaelklishin
approved these changes
Sep 16, 2019
|
I'm not sure about the precedent this is setting. We could simply update the |
michaelklishin
deleted the
rabbitmq-java-client-classes-for-update-secret-extension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CI testing jobs are using the 3.7 branch of codegen, which does not contain
the update-secret extension. The Java client then cannot be built
because it requires some generated code for the extension.
This commit adds the code to handle update-secret and thus
makes the generated code not necessary. This is just a workaround for
these testing jobs to succeed, it does not change the handling of the
update-secret extension in the client.
[#167029587]
References #626