Remove dependency on java.sql.Timestamp #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only one condition test refers to java.sql.Timestamp and it's unnecessary anyway because it also refers to java.util.Date (Timestamp inherits from Date). Only the Date API is then used to marshall and unmarshall values. This avoids a dependency on the java.sql module, which some SDK does not seem to contain (e.g. JavaFX, reported by a user). This should also avoid needing this module in some Docker images (e.g. PerfTest, which pulls this module in its stripped JRE just for this reference apparently). Mailing list thread: https://groups.google.com/g/rabbitmq-users/c/ORX91PwYhnw/m/xlMR9JTTAQAJ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only one condition test refers to java.sql.Timestamp and it's unnecessary anyway because it also refers to java.util.Date (Timestamp inherits from Date). Only the Date API is then used to marshall and unmarshall values.
This avoids a dependency on the java.sql module, which some SDK does not seem to contain (e.g. JavaFX, reported by a user). This should also avoid needing this module in some Docker images (e.g. PerfTest, which pulls this module in its stripped JRE just for this reference apparently).
Mailing list thread: https://groups.google.com/g/rabbitmq-users/c/ORX91PwYhnw/m/xlMR9JTTAQAJ