Periodically reconcile virtual host processes #11363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
force-pushed
the
mk-make-sure-virtual-hosts-are-started-on-all-nodes-after-definition-import
branch
2 times, most recently
from
ff0cf27 to
41dcab0
Compare
|
Investigating the |
michaelklishin
force-pushed
the
mk-make-sure-virtual-hosts-are-started-on-all-nodes-after-definition-import
branch
from
41dcab0 to
a8d4451
Compare
|
I will add a CLI command as discussed with @dcorbacho @mkuratczyk. |
michaelklishin
force-pushed
the
mk-make-sure-virtual-hosts-are-started-on-all-nodes-after-definition-import
branch
7 times, most recently
from
e9d373e to
6831880
Compare
dcorbacho
reviewed
Jun 6, 2024
|
|
||
| %% Same as rabbit_vhost:exists/1. | ||
| -spec exists(vhost:name()) -> boolean(). | ||
| exists(VirtualHost) -> |
There was a problem hiding this comment.
Nothing against it, but why this function here? I can't see where it is being used.
There was a problem hiding this comment.
In fact, exists/1, and list_names/1 already exist in rabbit_vhost. Why not use them?
There was a problem hiding this comment.
Some virtual host functions are in rabbit_vhost, others are in the supervision tree-related modules. We need a place for all key functions.
There's also a comment at the top that explains why the module was originally introduced:
%% This module exists to avoid circular module dependencies between
%% several others virtual hosts-related modules.
for up to 10 times. When a cluster is formed from scratch and a virtual host is declared in the process (can be via definitions, or plugins, or any other way), that virtual host's process tree will be started on all reachable cluster nodes at that moment in time. However, this can be just a subset of all nodes expected to join the cluster. The most effective solution is to run this reconciliation process on a timer for up to 5 minutes by default. This matches how long some other parts of RabbitMQ (3.x) expect cluster formation to take, at most. Per discussion with @dcorbacho @mkuratczyk.
… have come online
Certain test suites need virtual hosts to be down for an extended period of time, and this feature gets in a way ;)
michaelklishin
force-pushed
the
mk-make-sure-virtual-hosts-are-started-on-all-nodes-after-definition-import
branch
from
0f1c49f to
959d3fd
Compare
|
Something is up with Actions, they are not picking up my latest changes. Will submit a new PR instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for up to 10 times.
When a cluster is formed from scratch and a virtual host is declared in the process (can be via
definitions, or plugins, or any other way),
that virtual host's process tree will be started
on all reachable cluster nodes at that moment
in time.
However, this can be just a subset of all nodes
expected to join the cluster.
The most effective solution is to run this
reconciliation process on a timer for up to
5 minutes by default. This matches how long
some other parts of RabbitMQ (3.x) expect
cluster formation to take, at most.
Per discussion with @dcorbacho @mkuratczyk.