fix: sr-only notification #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: adamstankiewicz <[email protected]>
…enedx#1287) * Adds new React hook `useIndexOfLastVisibleChild` to provide a mechanism to determine the last element in a container, accounting for when the screen width changes. * Utilizes `useIndexOfLastVisibleChild` in the `Tabs` component to ensure the tabs don't wrap; that is, they now remain on a single line and show a "More" dropdown when there is overflow.
Co-authored-by: adamstankiewicz <[email protected]>
# [19.24.0](openedx/paragon@v19.23.1...v19.24.0) (2022-05-27) ### Features * [BD-46] exports useIndexOfLastVisibleChild, responsive tabs ([openedx#1287](openedx#1287)) ([75311f6](openedx@75311f6))
* feat: add all MUI icons * feat: add missing icons from MUI
# [19.25.0](openedx/paragon@v19.24.0...v19.25.0) (2022-05-27) ### Features * [BD-46] add all MUI icons ([openedx#1313](openedx#1313)) ([404692e](openedx@404692e))
Co-authored-by: adamstankiewicz <[email protected]>
viktorrusakov
force-pushed
the
lytvynenko/sr_only_notification
branch
from
7ebad0b
to
de3274e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Tabs with a notification using the Voiceover screen reader, it does read aloud the contents of the notification bubble, but there’s no other information “spoken” about the number being displayed on tab. So, as a user with a visual impairment, the notification count might not be obvious what it’s referring to.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
exampleapp?wittjeffandadamstankiewiczas reviewers on this PR.Post-merge Checklist