Public info

[RSTJNII]

Merge Thomas C's public_info Ohai plugin into rackops_rolebook

[RSTJNII]

Question to the floor: Where do we want to have our "default" attribute location be for the external IP? Currently it is in public_info.remote_ip, is this sufficient or should we save it in another location as well?

[doublerr]

@RSTJNII public.info.external_ip?

Also just a reminder about tags. As Discussed, we can set a tag as "external_ip: 1.1.1.1" as an example

[RSTJNII]

public_info.remote_ip is already being consumed in customer environments and so I think it should be retained. I don't think having a second attribute, public_info.external_ip, in the same subhash adds value. I opted to leave naming alone, and made the tag RemoteIP to keep things consistent.

Tagging is working. Note that the tag is just a string, not a key:value pair.

$ knife tag list web-stg-dfw-01
RemoteIP:50.56.152.222

[prometheanfire]

Should be good, but can we get a test?

[RSTJNII]

This is failing tests. Will resubmit once testing is resolved.

[RSTJNII]

Cookbook doesn't appear to be in Jenkins, passes on my box:

rackops_rolebook $ bundle exec rake; echo $?
<Snip run>
-----> Destroying <default-debian-720>...
       [default] Forcing shutdown of VM...
       [default] Destroying VM and associated drives...
       Vagrant instance <default-debian-720> destroyed.
       Finished destroying <default-debian-720> (0m8.10s).
0

I added an exception into the recipe if this doesn't run properly as I believe an explicit convergence failure is better than bad data or a failure somewhere where the data is consumed. This also serves as a simple test as if any of the moving parts aren't moving node['public_info'] won't be set leading to a convergence failure during kitchen tests.

Rubocop revision was also dropped to a known working revision as RuboCop 0.21 and 0.20 were throwing dependency errors on my box.

[martinb3]

👍 from me.

[RSTJNII]

Test still passing after master merge:

rackops_rolebook $ bundle exec rake
<Snip Run>
-----> Destroying <default-debian-720>...
       [default] Forcing shutdown of VM...
       [default] Destroying VM and associated drives...
       Vagrant instance <default-debian-720> destroyed.
       Finished destroying <default-debian-720> (0m6.03s).
rackops_rolebook $ echo $?
0