Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start and stop support in class Server #462

Merged
merged 2 commits into from
Nov 19, 2014
Merged

Add start and stop support in class Server #462

merged 2 commits into from
Nov 19, 2014

Conversation

notFloran
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 37e0414 on Hexanet:server-start-stop into 054f9b2 on rackspace:working.

@ycombinator
Copy link
Contributor

Hi @notFloran,

According to http://docs.openstack.org/api/openstack-compute/2/content/ext-os-server-start-stop.html, the status code of the responses for these operations should be 202 instead of 204. Could you please update your tests to match this? Otherwise, this looks great!

Thanks,

Shaunak

@notFloran
Copy link
Contributor Author

Hi @ycombinator,

I update the tests with 202 instead of 404.

ycombinator added a commit that referenced this pull request Nov 19, 2014
Add start and stop support in class Server
@ycombinator ycombinator merged commit 23d19f3 into rackspace:working Nov 19, 2014
@ycombinator
Copy link
Contributor

Thanks @notFloran!

@notFloran notFloran deleted the server-start-stop branch November 19, 2014 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants