-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding create server with network sample #468
Adding create server with network sample #468
Conversation
'networks' => array( | ||
$customNetwork, | ||
$computeService->network(Network::RAX_PRIVATE), // This is the internal Rackspace network - strongly recommended | ||
$computeService->network(Network::RAX_PUBLIC), // This is the public internet - strong recommended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we strongly recommend these networks, I'd like to know why, as a user. I know there's no space here to explain that so I don't have a good solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't those created by default? We shouldn't have to explicitly add them here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamiehannaford can correct me here, but I believe if you specify any networks at all, you must explicitly specify which ones you want, including ServiceNet and PublicNet (?). On the other hand, if you don't specify any networks, ServiceNet and PublicNet are automatically added to the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just tested and if you do not provide RAX_PRIVATE
or RAX_PUBLIC
they aren't added - so we'll need to keep them in this sample. I wanted to avoid lots of additional explanation in the comments because AFAIK these are fairly standard terms and already have documentation to explain them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to avoid lots of additional explanation in the comments because AFAIK these are fairly standard terms and already have documentation to explain them
Then perhaps remove the recommendation bit altogether?
Done :squirrel: |
Adding create server with network sample
No description provided.