Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding create server with network sample #468

Merged
merged 2 commits into from
Nov 21, 2014

Conversation

jamiehannaford
Copy link
Contributor

No description provided.

'networks' => array(
$customNetwork,
$computeService->network(Network::RAX_PRIVATE), // This is the internal Rackspace network - strongly recommended
$computeService->network(Network::RAX_PUBLIC), // This is the public internet - strong recommended
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we strongly recommend these networks, I'd like to know why, as a user. I know there's no space here to explain that so I don't have a good solution.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't those created by default? We shouldn't have to explicitly add them here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamiehannaford can correct me here, but I believe if you specify any networks at all, you must explicitly specify which ones you want, including ServiceNet and PublicNet (?). On the other hand, if you don't specify any networks, ServiceNet and PublicNet are automatically added to the server.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tested and if you do not provide RAX_PRIVATE or RAX_PUBLIC they aren't added - so we'll need to keep them in this sample. I wanted to avoid lots of additional explanation in the comments because AFAIK these are fairly standard terms and already have documentation to explain them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to avoid lots of additional explanation in the comments because AFAIK these are fairly standard terms and already have documentation to explain them

Then perhaps remove the recommendation bit altogether?

@jamiehannaford
Copy link
Contributor Author

Done :squirrel:

ycombinator added a commit that referenced this pull request Nov 21, 2014
Adding create server with network sample
@ycombinator ycombinator merged commit 0c29938 into rackspace:working Nov 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants