typofixes - https://github.com/vlajos/misspell_fixer #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,7 +56,7 @@ class Logger extends AbstractLogger | |||
| 'outputToFile' => false, | |||
| 'logFile' => null, | |||
| 'dateFormat' => 'd/m/y H:I', | |||
| 'delimeter' => ' - ' | |||
| 'delimiter' => ' - ' | |||
There was a problem hiding this comment.
This needs to be reverted because, as @GrahamCampbell says, it's a backwards incompatible change that would break semantic versioning.
|
Should I revert the related parts? Or can we fix this somehow? |
| @@ -20,7 +20,7 @@ For a complete list of features, [view the official page](http://guzzlephp.org). | |||
|
|
|||
| ## Keypair support | |||
|
|
|||
| Although code now exists in the SDK for API compatability for creating servers with keypairs, there has been | |||
| Although code now exists in the SDK for API compatibility for creating servers with keypairs, there has been | |||
|
@vlajos Hi Veres, thanks for this - it's very useful! I've gone through and highlighted the areas that need to be reverted, due to semantic versioning. Also, could you rebase your branch against |
vlajos
force-pushed
the
typofixes-vlajos-20141204
branch
from
f1f264e to
8cfb1a6
Compare
|
Ok. Done. |
|
Changes Unknown when pulling 8cfb1a6 on vlajos:typofixes-vlajos-20141204 into * on rackspace:working*. |
jamiehannaford
pushed a commit
that referenced
this pull request
Dec 5, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.