refactored load balancer node adding to use one request instead of se… #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…veral in parallel
jamiehannaford
pushed a commit
that referenced
this pull request
Jan 12, 2016
…uest refactored load balancer node adding to use one request instead of se…
|
Great idea, thanks @dansoap 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the SDK to add more than one node to an existing load balancer, it is very likely, that at least one request fails with a 422 (Unprocessable Entity) error, since the load balancer is in state PENDING_UPDATE after the first request has been processed.
This PR changes the call to the API so that there are not several parallel requests, but just one, adding all nodes to add in just one call.