Update expressions.md : right and left shift must be >> and << #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trufae
reviewed
Aug 13, 2021
| * \> : shift right | ||
| * < : shift left | ||
| * \>> : shift right | ||
| * << : shift left |
There was a problem hiding this comment.
there's also <<< and >>> which rotate the bits instead of shifting them. and im now working on fixing < and > because that may result on 1 or 0 as its a comparison operator (and adding tests)
There was a problem hiding this comment.
mind to update the doc with those operators too?
There was a problem hiding this comment.
no need to wait that much to merge this, ill update the esil documentation when i get some spare time. thanks for the contribution!
There was a problem hiding this comment.
@trufae somehow missed your comment about >>>
Let me check them and add into doc as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
...
Test plan
...
Closing issues
...