Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell how to write IO plugins in the IO plugin chapter. #349

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

gogo2464
Copy link
Contributor

Checklist

  • Closing issues: #issue
  • Mark this if you consider it ready to merge
  • I've added tests (optional)
  • I wrote some documentation

Description

src/plugins/ioplugins.md Outdated Show resolved Hide resolved
src/plugins/ioplugins.md Outdated Show resolved Hide resolved
src/plugins/ioplugins.md Outdated Show resolved Hide resolved
src/plugins/ioplugins.md Outdated Show resolved Hide resolved
src/plugins/ioplugins.md Outdated Show resolved Hide resolved
src/plugins/ioplugins.md Outdated Show resolved Hide resolved
src/plugins/ioplugins.md Outdated Show resolved Hide resolved
@gogo2464 gogo2464 force-pushed the io-plugin-tutorial branch from 20b77ec to 5ffadbb Compare August 16, 2022 08:46
@gogo2464
Copy link
Contributor Author

@trufae sounds ready to merge.

@trufae
Copy link
Contributor

trufae commented Aug 24, 2022

Thanks for the reminder. Yes lgtm. But it will be good if the code snippets could follow the coding style guideliness. There are missing braces, missing spaces, unnecessary comments.. im fine to merge it like this. There are probably other code snippets that dont match in the book.

can you do this fix quick before i merge? Thanks!

@trufae trufae merged commit fa8ef0f into radareorg:master Sep 16, 2022
@trufae
Copy link
Contributor

trufae commented Sep 16, 2022

Ill fix the indents

fengjixuchui added a commit to fengjixuchui/radare2-book that referenced this pull request Nov 4, 2022
Tell how to write IO plugins in the IO plugin chapter. (radareorg#349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants