Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

High Memory Usage #308

Open
krisdestruction opened this issue Apr 27, 2015 · 7 comments
Open

High Memory Usage #308

krisdestruction opened this issue Apr 27, 2015 · 7 comments
Milestone

Comments

@krisdestruction
Copy link

I get that Google Music sends Radiant Player has a lot of high quality images that needs to be stored in RAM and that it has to load the entire library. However I'm pretty sure that the app can be more lean on memory by at least compressing some of those images, or reduce memory usage through some other optimization.

Adding both the memory and compressed memory values as seen below, Radiant Player is using more than 400 Mb of RAM. On a MBA with 4GB of RAM, that's immense (10%)!
screen shot 2015-04-27 at 7 05 56 pm

The app is running full screen and I wasn't playing any music at the time. I restarted and I get 141 MB of memory used, but that is still significant relatively speaking.

screen shot 2015-04-27 at 7 10 27 pm

Using version 1.3.3

@krisdestruction
Copy link
Author

For reference, I have 81 artists and 154 albums in my library. So I don't think most of this memory is used by the album art and my reasoning is as follows:

This is a sample of my Listen Now page.
screen shot 2015-04-27 at 7 18 47 pm

A screenshot (PNG which is MUCH larger in file size than a JPG) of Nick Jonas is below which is only 131 KB using my screen resolution.

screen shot 2015-04-27 at 7 18 21 pm

Assuming this is the average size of an album art image, all the album art images should only take (81+154)*125/1024)*125/1024 = 28.7 MB of RAM + 1 song (the one that's playing). The rest of the memory is logically what Radiant Player uses which is HUGE. Even if my assumption about caching album art is valid, then this is poorly optimized. I really don't think all this album art would be cached since you need an active internet connection for Radiant Player to work in the first place.

@davidharrison92
Copy link

Seeing something similar. 4GB after a day's use in total.

@krisdestruction
Copy link
Author

Issue still occurs in 1.4.0
screen shot 2015-09-29 at 3 22 51 pm

@jcady
Copy link

jcady commented Oct 27, 2015

Still occurs in 1.4.1. Switched to using Google Music in a Chrome tab and low and behold, my memory was reaching ~2GB for that tab after a few hours of playing. Unless it's just a coincidence, it looks like there's a memory leak in Google Music in general.

https://www.reddit.com/r/googlemusic/comments/3n3qun/memory_leak_in_google_play_music_on_chrome_v45/

@JoshuaLyle
Copy link

JoshuaLyle commented Oct 26, 2016

This problem still occurs in 1.11.2. Fills all physical RAM and heavily bleeds over to swap. This is from average use and keeping the program open for extended suspends and resumes. Usually gets this big from keeping it open for a day or two.

screen shot 2016-10-14 at 4 13 48 pm

@jacobwgillespie
Copy link
Member

@JoshuaLyle what's your environment like? What OS / Device / geographic region / language etc.? Anything installed that would affect the network or browsers (specifically Safari, since Radiant uses an embedded Safari window)?

@JoshuaLyle
Copy link

OSX 10.12 Sierra. United States. English.

I have 3 Safari extensions, AdBlock, Ghostery, and Reddit Enhancement Suite. Nothing that would affect networking

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants