-
Notifications
You must be signed in to change notification settings - Fork 259
Conversation
2f79e56
to
013c189
Compare
@radiant-player/radiant-player-mac this is ready for review |
If you'd like to test this, try running |
Just a thought - as this is triggered by Travis, does this mean it'll automatically deploy after any commit to master? |
Yes, that is correct and is by design. For the website, any commit to master will sync gh-pages with the website. It is limited to the master branch, so other branches won't go to gh-pages. I think this is the behavior we want for the website. For automatically building the app itself, that will have some different logic (based on tags, so that when we tag |
Seems to be a merge conflict in index.html. Let me know when that's sorted and I'll check it out. And don't forget to port over the PR from last night as I think it's included in the "old" section ;-) |
013c189
to
a1e13ff
Compare
* Removes unused image, JS, and CSS assets * Replaces Slick (the image carousel) with an updated version on a CDN (mainly for https support) * Optimizes image assets to reduce bandwidth * Adds Jekyll with templated release notes, homepage, and appcast (for app updates) * Integrates with automated Travis builds
Okay, merge conflicts are resolved and this should be good to go |
Yo - haven't forgotten. Just getting a Trying to work it out now. If it is specific ruby gems that need installing, will these need specifying in the travis config? |
Bundler is assumed to exist already (it's commonly installed with ruby) and is preinstalled on Travis. On your local machine, you can |
Oh, and once you have bundler installed, you run |
a1e13ff
to
973bcc0
Compare
Spent the past 2 minutes trying to work out what that notification sound was - turns out it was GitHub telling me you'd replied. This is what happens when I don't have music playing 😧 OK, will try that and report back shortly! |
Oh and I went through the changelog - nice one logging the ticket. I'll push that up too when I'm done with this. |
I just rebased this - you may need to re-pull |
Will do 👍 |
I have a |
Only issue with the build process was Aside from that, seems to be looking good. Though I'm making a mental note to rewrite that carousel to be pure CSS - the performance of that slick slider is awful. |
That's the html test tool - we can fix later I think... Merging! @andrewnorell, ready for the favicon! |
Build website with Jekyll
This depends on #433 getting merged first.