Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Added playbar rating fill for rdiant theme #462

Merged
merged 1 commit into from
Dec 20, 2015

Conversation

chrismou
Copy link
Member

Added fix for ratings thumbs in the now playing bar not having a fill on Rdiant theme

@jacobwgillespie
Copy link
Member

LGTM :shipit:

@chrismou, after you've merged, can you release this as 1.6.1? Will be good practice for releases. The process is:

  • checkout master and make sure it's up to date
  • run ./scripts/prepare-release.sh patch (major, minor, patch) and follow the prompts
  • run git push --tags once it's completed

@jacobwgillespie
Copy link
Member

Well, ./scripts/prepare-release.sh patch :)

@chrismou
Copy link
Member Author

Sounds good, I'll give it a go.

Don't want to start deluging users with updates, but good for a bit of practice ;-)

chrismou added a commit that referenced this pull request Dec 20, 2015
Added playbar rating fill for rdiant theme
@chrismou chrismou merged commit 1bfe5ed into radiant-player:master Dec 20, 2015
@chrismou chrismou deleted the bug/rdiant-ratings branch December 20, 2015 00:07
@chrismou
Copy link
Member Author

OK, there we go. Let's see what happens 👍

@jacobwgillespie
Copy link
Member

It worked, congrats!

@chrismou
Copy link
Member Author

@jacobwgillespie Hats off to you, that whole process was pretty slick. Really good work.

@chrismou
Copy link
Member Author

Ah wait, looks like the github pages site hasn't updated http://radiant-player.github.io/radiant-player-mac/

Was there another command to run to do that?

@jacobwgillespie
Copy link
Member

No, it happens as part of the build... It looks like probably the website got built before GitHub cleared their release cache. I may need to look into how to circumvent that scenario.

For now, if you want it to build the website again, just git commit --allow-empty -m 'Bump to build website' and push that to master.

@jacobwgillespie
Copy link
Member

So, somehow your tag didn't get pushed as master (I'm guessing it pushed only the tag and not master). I fixed that!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants