This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Object.assign() Fix #632
Merged
Object.assign() Fix #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Object.assign() returns undefined making a lot of the functionality broken with Radiant Player. Adding a Polyfill will resolve this issue in the webView Images of the bug: http://i.imgur.com/0qvzALG.png http://i.imgur.com/4BtRGA0.png
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloaded the new version of Radiant Player (v1.11.3) and noticed no notifications showed and the mini player stated 'No song currently playing' even upon change for a new song.
Taking a look at the console revealed that
Object.assign()returns undefined making a lot of the functionality broken with Radiant Player.Adding a Polyfill will resolve this issue in the webView
Images of the bug:
Edit:
Tested this on Mavericks, Yosemite, El Capitan and Sierra.
Issue is only present in Mavericks and Yosemite
but either way if
Object.assign() == undefined => !!1it will inject the Polyfill fix otherwise ignores ;)