fix a few minor openapi spec issues, upgrade remark and spectral #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philvarner
commented
Mar 10, 2022
| @@ -3,6 +3,6 @@ rules: | |||
| openapi-tags: off | |||
| info-contact: off | |||
| oas3-api-servers: off | |||
| oas3-unused-components-schema: off | |||
| oas3-unused-component: off | |||
There was a problem hiding this comment.
the name of this changed between spectral 5 and 6
philvarner
commented
Mar 10, 2022
children/openapi.yaml
Outdated
| @@ -107,16 +107,6 @@ components: | |||
| application/json: | |||
| schema: | |||
| $ref: '#/components/schemas/children' | |||
| InvalidParameter: | |||
There was a problem hiding this comment.
latest spectral determined these are unused
|
We have this configured to fail on warnings now, so putting this in draft until we figure out why the max-line-lenght rule is triggering on tables |
added 2 commits
March 11, 2022 13:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): n/a
Proposed Changes:
PR Checklist:
stac-specdirectory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)