revise limit semantics #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philvarner
requested review from
cholmes,
jbants,
lossyrob,
m-mohr and
matthewhanson
m-mohr
reviewed
Oct 10, 2022
m-mohr
requested changes
Oct 10, 2022
philvarner
commented
Oct 10, 2022
philvarner
commented
Oct 10, 2022
m-mohr
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
LGTM. OAFeat also says:
A 400 will be returned in the following situations: If query parameter limit is not an integer or not between minimum and maximum;
Not sure whether we should cover this here though. (Also not a big fan of returning a 400 in case you are outside of the min/max bounds.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Proposed Changes:
PR Checklist:
stac-specdirectory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)