-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(examples): change epsg summary example to an array of all values #1162
Conversation
stac-fields is not normative and just a recommendation. |
My bad, the collection examples were generated by the items aggregator function of DotNetStac. I fixed it to use single value when min/max are the same. |
`proj:epsg` should be summarised as an array of all values, not a Range Object, per [stac-fields](https://github.com/stac-utils/stac-fields/blob/v1.0.0-beta.10/fields.json#L575) and [other examples](https://github.com/radiantearth/stac-spec/blob/v1.0.0/examples/collection-only/collection.json#L90).
88735fd
to
44ae12b
Compare
As a real world example... we have a topographical 1:50,000 map series of georeferenced rasters that covers New Zealand, the Chatham Islands and Niue. Same map series showing same features / cartography, just different islands in the Pacific using different projections. The epsg codes involved are So
makes little sense as a summary because it implies that our Collection contains epsg codes spanning a huge range, whereas
summarises precisely which epsg codes are in-use within the Collection and seems much more useful. In general, we have been struggling a bit with implementing summaries because there are rarely examples or guidance on how to implement - the projection extension doesn't have a Should we be working towards consistency on how summaries are implemented for specific fields or is it really just intended that as long as we pick 1 of the 3 specified methods of summarising, that's fine?
Oops, I thought I did that, sorry. I have now reset my branch onto |
I did not mean to say you need to encode everything in Range objects. The structure you choose needs to fit to the data you are summarizing. In your example a list makes sense, of course. But if you have a summary of all UTM zones, it could be encoded as a Range as it contains all codes from 32601 - 32667 (or so, haven't checked closely the exact range).
Yes, because that's totally fine. Summaries can use the structure that suits the underlying data best.
Yes, that's the case. Sure, there are (community) recommendations (e.g. in STAC Fields package), but in principle, you can do whatever you want as long as it complies with the spec. |
This works for all UTM zones but it doesn't work for all subsets of contiguous UTM zones - if a Collection extent was the Pacific Ocean, you'd have 2 separate ranges so would have to use an array of values. |
Related Issue(s): #
N/A
Proposed Changes:
proj:epsg
should be summarised as an array of all values, not a Range Object, per stac-fields and other examples.PR Checklist:
or a CHANGELOG entry is not required.
and I have opened issue/PR #XXX to track the change.