Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update description for bbox property in item-spec.md #1206

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

nkleinbaer
Copy link
Contributor

@nkleinbaer nkleinbaer commented Dec 29, 2022

Related Issue(s): #
None

Proposed Changes:

  1. Update the description for the bbox property in item-spec.md to indicate that bbox is forbidden when geometry is null

If this was a new requirement it would be a breaking change, but IMO this is simply an editorial change to make the markdown more accurately describe a requirement that is already present in the schema:

{
"type": "object",
"required": [
"geometry"
],
"properties": {
"geometry": {
"type": "null"
},
"bbox": {
"not": {}
}
}
}

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr requested review from cholmes and m-mohr January 5, 2023 10:54
@m-mohr m-mohr added this to the 1.0.1 milestone Jan 5, 2023
@m-mohr
Copy link
Collaborator

m-mohr commented Jan 9, 2023

Thank you.

@m-mohr m-mohr merged commit bdd391a into radiantearth:dev Jan 9, 2023
@nkleinbaer nkleinbaer deleted the update_bbox_description branch January 9, 2023 18:24
@m-mohr m-mohr modified the milestones: 1.0.1, 1.1 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants