Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify wording regarding uniqueness of collection IDs #1209

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Clarify wording regarding uniqueness of collection IDs #1209

merged 2 commits into from
Feb 1, 2023

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Jan 9, 2023

Related Issue(s): #1201

Proposed Changes:

  1. As discussed in the PSC meeting, this clarifies the wording regarding the uniqueness of collection IDs. This superceedes PR Fix a missing pluralization #1201.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr added this to the 1.0.1 milestone Jan 9, 2023
@m-mohr m-mohr mentioned this pull request Jan 9, 2023
Closed
4 tasks
kurtmckee
kurtmckee approved these changes Jan 14, 2023
View reviewed changes
Copy link

@kurtmckee kurtmckee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads better to me. Thanks for discussing and improving this text!

@m-mohr m-mohr changed the title Clarify working regarding uniqueness of collection IDs Clarify wording regarding uniqueness of collection IDs Jan 29, 2023
@m-mohr m-mohr requested a review from emmanuelmathot January 31, 2023 14:52
emmanuelmathot
emmanuelmathot approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@emmanuelmathot emmanuelmathot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better indeed.

@m-mohr m-mohr merged commit a9aacbc into dev Feb 1, 2023
@m-mohr m-mohr modified the milestones: 1.0.1, 1.1 May 2, 2023
@m-mohr m-mohr deleted the unique-collection-ids branch July 31, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelmathot emmanuelmathot emmanuelmathot approved these changes

@cholmes cholmes cholmes approved these changes

@kurtmckee kurtmckee kurtmckee approved these changes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

@lossyrob lossyrob Awaiting requested review from lossyrob

@jbants jbants Awaiting requested review from jbants

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0-beta.1
Development

Successfully merging this pull request may close these issues.
4 participants
@m-mohr @kurtmckee @cholmes @emmanuelmathot