Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keywords in common metadata #1227

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Keywords in common metadata #1227

merged 3 commits into from
Jun 6, 2023

Conversation

emmanuelmathot
Copy link
Collaborator

@emmanuelmathot emmanuelmathot commented Apr 13, 2023

Related Issue(s): #1187

Proposed Changes:

  1. Keywords fields in common metadata to have it available in Stac Item

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@emmanuelmathot emmanuelmathot added this to the 1.1 milestone Apr 13, 2023
@emmanuelmathot emmanuelmathot changed the base branch from master to dev April 13, 2023 10:15
@emmanuelmathot
Copy link
Collaborator Author

Not sure it affect STAC API spec

Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The collection should still have keywords, just referenced from the common metadata. So no change in Collections except that the schema lives somewhere else.

No effect on STAC API, I think.

@emmanuelmathot
Copy link
Collaborator Author

isn't it included automatically with the common metadata inclusion?

"$ref": "../../item-spec/json-schema/common.json#"

@m-mohr
Copy link
Collaborator

m-mohr commented Apr 13, 2023

Good point, I'll check...

Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation works flawlessly in Items, Catalogs and Collections.

I made some minor textual changes for clarification. Looks good to be merged :-)

@m-mohr
Copy link
Collaborator

m-mohr commented Apr 25, 2023

@cholmes @matthewhanson Would someone be willing to review this?

@m-mohr m-mohr linked an issue Apr 29, 2023 that may be closed by this pull request
@m-mohr m-mohr requested a review from constantinius June 6, 2023 12:34
@m-mohr m-mohr merged commit 25d56b0 into dev Jun 6, 2023
@m-mohr m-mohr deleted the keywords-common branch June 6, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend common metadata by keywords
3 participants