Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ci node to 18 and format all files #1249

Merged

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented Sep 26, 2023

Related Issue(s):

n/a

Proposed Changes:

  1. Update CI node to 18
  2. Move remark configuration to package.json
  3. Format all files in line with remark-gfm formatting

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@m-mohr
Copy link
Collaborator

m-mohr commented Sep 27, 2023

+1 on the Node updates (maybe better as a separate PR?)

Not so sure whether we want all the noise of the formatting changes in the diff?

@philvarner
Copy link
Collaborator Author

+1 on the Node updates (maybe better as a separate PR?)

Not so sure whether we want all the noise of the formatting changes in the diff?

I put these two "housekeeping" tasks together in the same PR because it was easier. I'd think differently if they were actual changes.

@matthewhanson matthewhanson merged commit 1ca1a41 into radiantearth:dev Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants