Docker hub tags outdated raiden version as latest

[nephix]

Problem Definition

When pulling the docker image raidennetwork/raiden:nightly, raidennetwork/raiden:latest or raidennetwork/raiden:v0.200.0-rc1 I would expect to get the latest RC.

Actual result

Docker pulled the version 0.100.5a1.dev504+g68448ac97:

$ docker run -it raidennetwork/raiden:v0.200.0-rc1
Unable to find image 'raidennetwork/raiden:v0.200.0-rc1' locally
v0.200.0-rc1: Pulling from raidennetwork/raiden
Digest: sha256:373170d05c6cb528e1502848b61c65b421e67564c71c7785d46da0f9662d8ec5
Status: Downloaded newer image for raidennetwork/raiden:v0.200.0-rc1
Welcome to Raiden, version 0.100.5a1.dev504+g68448ac97!
...

System Description

$ docker -v
Docker version 19.03.2, build 6a30dfc

[konradkonrad]

It seems, that the container was build from the develop branch, since on the master branch python setup.py --develop returns the correct RAIDENVERSION.

[rakanalh]

@konradkonrad where do we build/push the docker container?

[konradkonrad]

circleCI has a docker stage for nightly builds. still trying to figure out, where the release builds are generated

[konradkonrad]

the version tagged releases are auto-build from dockerhub. I disabled the "build caching" for the release builds and try to retrigger a build

[konradkonrad]

I found the culprit in the build logs from dockerhub for Build in 'v0.200.0-rc1:/docker/Dockerfile' :

Step 3/13 : ARG RAIDENVERSION=develop
---> Running in 1afe700a0631

[konradkonrad]

this "fails", because on dockerhub, there is no build argument provided, and instead the default is used:

# use --build-arg RAIDENVERSION=v0.0.3 to build a specific (tagged) version
ARG REPO=raiden-network/raiden
ARG RAIDENVERSION=develop

[konradkonrad]

We will need to optionally set Build Environment Variables (on dockerhub build settings) for tagged releases, so that RAIDENVERSION=${SOURCE_BRANCH} (see https://docs.docker.com/docker-hub/builds/advanced/), when building a tagged commit.

I am not sure if this is going to work (or break other things), but I will try.

[konradkonrad]

okay, it seems that we need to add a build hook in order to pass SOURCE_BRANCH as RAIDENVERSION. See: docker/hub-feedback#508 especially docker/hub-feedback#508 (comment)