Array#uniq to correctly identify == GlobalIDs #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing an Array#uniq with two GlobalID objects that are
==
, the result of the uniq still contains the "duplicate" entries.This PR changes the
hash
method to consider thehash
of the underlaying URI hash so that two GlobalID objects pointing to the same object are considered duplicates of each other.Previously, with:
p1 = GlobalID.create(Person.new(1))
p2 = GlobalID.create(Person.new(1))
p1 == p2 #=> true
but[p1, p2].uniq #=> [p1, p2]