Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GlobalID::Identification clears memoized to_global_id on dup #109

Merged
merged 2 commits into from
Aug 24, 2018
Merged

GlobalID::Identification clears memoized to_global_id on dup #109

merged 2 commits into from
Aug 24, 2018

Commits on Aug 22, 2018

  1. GlobalID::Identification clears memoized to_global_id on dup 

    This module is used in ActiveRecord, which resets the model's primary key on
`dup`. If we don't clear it here, then a `dup`ed ActiveRecord instance can have
an invalid GlobalID.
    @bradleybuda
    bradleybuda committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    b9f78c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2018

  1. Remove memoization of GlobalID::Identification#to_global_id

    @bradleybuda
    bradleybuda committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    8b3af4c View commit details
    Browse the repository at this point in the history