Partially revert 4c933fb where #to_s was changed unintentionally.
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzak
referenced
this pull request
Nov 26, 2014
| @@ -89,7 +89,7 @@ def build(args) | |||
|
|
|||
| def to_s | |||
| # Implement #to_s to avoid no implicit conversion of nil into string when path is nil | |||
| "gid://#{app}#{path_query}" | |||
| "gid://#{app}/#{model_name}/#{model_id}" | |||
There was a problem hiding this comment.
This will break the build. We are expecting the query string too.
But path_query is not present in ruby-head. So maybe we should use "#{path}#{'?' + query if query}"
|
The change was intentional, but I wasn't aware that #50 includes Rafael's suggested solution, which works 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #44