Rename to actionview html sanitizer

[tongueroo]

Why

This PR renames the rails-html-sanitizer to actionview-html-sanitizer.

Currently, the rails-html-sanitizer is used in actionview and defines an empty Rails namespace. This makes it more challenging to use with frameworks like Jets, because once the Rails constant is defined, then other gems that do this:

some_gem/railtie.rb

require "some_gem/railtie" if defined?(Rails)

won't be able to be used with Jets. Renaming to actionview-html-sanitizer gives other gems a chance to work with Jets, also.

Note: The ideal way to check would for the other gems to use this instead:

require "some_gem/railtie" if defined?(Rails::Railtie)

It's a bummer, gems authors are not always aware of this.

Related

• Decouple ActionView and Rails HTML Sanitizer to Allow Other Frameworks to Use ActionView rails#49643
• use actionview-html-sanitizer rails#49714

[flavorjones]

How do you suggest we avoid breaking existing Rails apps that are referencing constants like Rails::Html::Sanitizer?

I appreciate that you're trying to solve a real problem, but I do not think that renaming this project and renaming the top-level module is an appropriate solution. At the very least, you are presuming that the maintainers of this library are willing to take on a great deal of work to ensure that existing applications aren't broken by this change, and I remain unconvinced that this library needs to own that responsibility.

[flavorjones]

It is not correct to change this name, these rules are defined in https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsassertnot with the Rails namespace.

[tongueroo]

Oops. Ok

[flavorjones]

It's inappropriate to make a version change in a feature PR.

[tongueroo]

Thank for the note.

[tongueroo]

All good, I understand. Can workaround for Jets. Closing out. Thanks for the response though!