Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: phantom wallet eip-6963 connector not appearing #2069

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Jun 28, 2024

Changes

  • Phantom wallet had \n prefix string to their icon url which caused it to not show up in "Installed" section in connect modal as an EIP-6963 connector.

@magiziz magiziz requested a review from a team as a code owner June 28, 2024 16:13
Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rainbowkit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 4:13pm
rainbowkit-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 4:13pm

@DanielSinclair DanielSinclair merged commit d02d73f into main Jul 2, 2024
9 checks passed
@DanielSinclair DanielSinclair deleted the @mago/phantom-wallet-eip6963-fix branch July 2, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Conflict between phantom Wallet and core wallet While connecting metamask User rejected request comes
2 participants