--enginesNode: Do not exclude packages with no engines.node (#1313).

raineorshine · Aug 16, 2023 · 0ffb0e8 · 0ffb0e8
1 parent 54184e0
commit 0ffb0e8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/package-managers/filters.ts b/src/package-managers/filters.ts
@@ -40,7 +40,7 @@ export function satisfiesNodeEngine(versionResult: Packument, nodeEngineVersion:
   const minVersion = get(semver.minVersion(nodeEngineVersion), 'version')
   if (!minVersion) return true
   const versionNodeEngine: string | undefined = get(versionResult, 'engines.node')
-  return !!versionNodeEngine && semver.satisfies(minVersion, versionNodeEngine)
+  return !versionNodeEngine || semver.satisfies(minVersion, versionNodeEngine)
 }
 
 /**

diff --git a/test/enginesNode.test.ts b/test/enginesNode.test.ts
@@ -46,12 +46,16 @@ describe('enginesNode', () => {
       enginesNode: true,
       packageData: {
         dependencies: {
-          del: '3.0.0',
+          'ncu-test-v2': '1.0.0',
+        },
+        engines: {
+          node: '>=6',
         },
       },
     })) as Index<VersionSpec>
 
-    const versionNew = parseInt(upgraded.del, 10)
-    versionNew.should.gt(4)
+    upgraded!.should.eql({
+      'ncu-test-v2': '2.0.0',
+    })
   })
 })