Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --engines-node functionality #602

Merged
merged 1 commit into from
Nov 3, 2019
Merged

Added --engines-node functionality #602

merged 1 commit into from
Nov 3, 2019

Conversation

vanodevium
Copy link
Contributor

Copy link
Owner

@raineorshine raineorshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think the overall direction is great.

The main issues are with view and latest. Otherwise there are just minor quality recommendations.

@vanodevium
Copy link
Contributor Author

@raineorshine Thanks for recommendations.
I tried to do as good as I can do. I apologize if at some points I misunderstood you.

@raineorshine
Copy link
Owner

Thank you so much for your persistence and willingness to work with the feedback! You've done more than most. Thanks for contributing to npm-check-updates!

@raineorshine raineorshine merged commit 742dbce into raineorshine:master Nov 3, 2019
@raineorshine
Copy link
Owner

@webdevium I did some further cleanup and conformance to the functional programming style in c417828 if you are curious.

@raineorshine
Copy link
Owner

Published in v3.2.0

@vanodevium
Copy link
Contributor Author

@raineorshine Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants