Skip to content

Commit

Permalink
Removed scheduler debugger from MSBuildDebugEngine (dotnet#10868)
Browse files Browse the repository at this point in the history
Fixes dotnet#10639

Context
There was an internal ticket that seems to originate from the scheduler logger. The team uses the engine debugger variable to keep track of their builds. However, it seems that the scheduler logger does not always work as expected and it is turned on when using MSBuildDebugEngine. Since we think there isn't a lot of information that is necessary from scheduler logger, we are trying to disable it when using the MSBuildDebugEngine variable, and leaving it on when explicitly turned on.

Changes Made
Does not turn on scheduler debugger when using MSBuildDebugEngine
  • Loading branch information
maridematte authored Oct 29, 2024
1 parent eeae6e9 commit ee511a9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion documentation/wiki/MSBuild-Environment-Variables.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Some of the env variables listed here are unsupported, meaning there is no guara
* Launches debugger on build start. Works on Windows operating systems only.
* Setting the value of 2 allows for manually attaching a debugger to a process ID. This works on Windows and non-Windows operating systems.
* `MSBUILDDEBUGSCHEDULER=1` & `MSBUILDDEBUGPATH=<DIRECTORY>`
* Dumps scheduler state at specified directory (`MSBUILDDEBUGSCHEDULER` is implied by `MSBuildDebugEngine`).
* Dumps scheduler state at specified directory.

* `MsBuildSkipEagerWildCardEvaluationRegexes`
* If specified, overrides the default behavior of glob expansion. During glob expansion, if the path with wildcards that is being processed matches one of the regular expressions provided in the [environment variable](#msbuildskipeagerwildcardevaluationregexes), the path is not processed (expanded).
Expand Down
2 changes: 1 addition & 1 deletion src/Framework/Traits.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public Traits()
{
EscapeHatches = new EscapeHatches();

DebugScheduler = DebugEngine || !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("MSBUILDDEBUGSCHEDULER"));
DebugScheduler = !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("MSBUILDDEBUGSCHEDULER"));
DebugNodeCommunication = DebugEngine || !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("MSBUILDDEBUGCOMM"));
}

Expand Down

0 comments on commit ee511a9

Please sign in to comment.