CSS fix for Text/Textarea input fields language selector #560
Conversation
mjauvin
commented
Mar 11, 2020
mjauvin
commented
- add registerBundle() calls to allow compiling LESS files into CSS
- make sure multi-lingual input form controls have padding-right of 44px
|
I noticed the language selector for textarea is problematic because of the scrollbar that appears dynamically once the content overflows: before scrollbar appears (language selector can be obscured by text): after scrollbar appears: I propose we change the location of the language selector OUTSIDE of the field to cope for this, see screenshot below:
What do you guys think? |
|
@mjauvin sounds good to me, just make sure it's on the same horizontal line as the field label |
|
@mjauvin You'll need to check the placement of the language selector when someone uses the |
|
@bennothommo good point. Look at the following screenshot of a textarea with commentAbove:
Is that what you would expect? |
|
@mjauvin If possible, it should line up with the lowest element in the "label" portion of the field, so in this case, it should probably line up with the comment. But otherwise, it looks fine to me. |
|
This is how it looks now with commentAbove:
|
mjauvin
changed the title
* runs params value through htmlspecialchars() to escape html content * add note about escaped content in translated messages * use Html::clean() instead of e() * Revert "add note about escaped content in translated messages" * escape params when translating messages; introduce transRaw method for legacy usage * Fix for #376 (#559) Fix for #376 * Add support for transOrderBy (#516) Add support for transOrderBy * update version file for 1.6.8 release * Disable safe mode checks for ML Static Pages. Fixes rainlab/pages-plugin#434. Refs: rainlab/pages-plugin#174, rainlab/pages-plugin@6b6b061 * Clear RainLab.Pages caches when saving a static page Fixes rainlab/pages-plugin#404 * Register asset bundle (#560) * make sure multi-lingual input form controls have padding-right of 44px * register asset bundle to process less files into css files * reposition language selector above textarea box * fix language selector position when commentAbove is defined * Update version file for 1.6.9 release * Fix error with casts fields default locale value (#556) * only call setLocale() if locale has changed (#561) * remove unused module Co-authored-by: Siarhei Karavai <[email protected]> Co-authored-by: Aurélien Roy <[email protected]> Co-authored-by: Ben Thomson <[email protected]> Co-authored-by: Luke Towers <[email protected]> Co-authored-by: Trysystems <[email protected]>
