-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fired events in the theme scanner. #576
Conversation
@bereznev please provide a real world use case for both proposed events. Additionally, please add inline event documentation (example here: https://github.com/octobercms/october/blob/develop/modules/backend/classes/Controller.php#L245-L263) |
I added an extra scan for the php classes. Using it allows you to add words list using constants (properties) to prevent duplication of these lists. And I need to automatically generate translation files after scanning. |
Please provide the code you use to listen to the event so I can better understand the purpose. |
|
…nslate.themeScanner.afterScan'.
Change the event names in all the places it's referenced please. |
LGTM! |
LGTM |
Fired events in ThemeScanner.php class for ability to extend scan method.