Add Semigroup implementation for Maybe #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. Just need to update the README table for Maybe x Semigroup; otherwise this looks fine to me -- any objections, anyone? |
|
Hah, fell at the last hurdle - sorted now! Apparently introduced a merge conflict, though, so sorry about that :( |
|
can you please resolve the conflict and amend the commit? |
added 2 commits
October 1, 2016 23:12
The concatenation method has been added for the two instances of the Maybe type. Accompanying tests (just QuickChecks for the semigroup laws) have also been added.
Forgot to add the tick! This commit updates the README to mention Maybe being a Semigroup.
|
All sorted! :) |
Closed
|
Thanks for your patience! This LGTM -- Gonna leave open until tomorrow to allow others to comment should they wish to -- otherwise I will merge then. |
|
🐪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concatenation method has been added for the two instances of the Maybe type. Accompanying tests (just QuickChecks for the semigroup laws) have also been added.
I've tried to keep the implementations consistent with the code around them, so let me know if there's anything to change and I'll update!