Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused symb section from docs page #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MattMS
Copy link
Member

@MattMS MattMS commented Oct 27, 2016

I cannot seem to find this being used on the site, not even in the older versions of the docs.

There are some styles for it that I have removed in another branch for a later PR.

@buzzdecafe
Copy link
Member

buzzdecafe commented Oct 27, 2016

#99

I think it is intended to be used?

ping @thurt

@buzzdecafe
Copy link
Member

there appears to be no code in publish.js to pick up the @symb tag, so it is being ignored

@MattMS
Copy link
Member Author

MattMS commented Oct 27, 2016

Ah right, so this should be closed and another issue opened to support @symb in publish.js?

@buzzdecafe
Copy link
Member

@symb doesn't seem to be in the code. hmmm
https://github.com/ramda/ramda.github.io/blob/master/docs/dist/ramda.js

@MattMS
Copy link
Member Author

MattMS commented Oct 27, 2016

Odd. Well I've grabbed the publish.js changes from #99 and converted them to Ramda code ready to be put in another PR.
I'll hold off until you can confirm if they are used, as I have no idea what they are! 😛

@buzzdecafe
Copy link
Member

i suspect a bad merge happened in there somewhere

@MattMS
Copy link
Member Author

MattMS commented Oct 27, 2016

#99 modifies jsdoc/publish.js which was removed by #143 because it was unused by the build scripts.

That doesn't explain why symb isn't used in dist/ramda.js though, since that is taken straight from the ramda package.

@buzzdecafe
Copy link
Member

seems to be in the source, e.g. https://github.com/ramda/ramda/blob/50758266f8afb18c38bc2de9a12a8a4bf9707b72/src/nthArg.js

so i would expect it to show up in the next release. so i think we can close this PR

@MattMS MattMS mentioned this pull request Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants