Use DeviceCodeErrorResponseType::ExpiredToken for expired Device #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a async example for using oauth2-rs library especially for device code workflow.
It is good to use RequestTokenError::ServerResponse for expired Device token instead of having a "Device code expired" string is set to Other(). We see to it that they are have the same Error with the error came from the endpoint. There was a timing issue found that expired_token is returned from the endpoint and sometimes the RequestTokenError::Other() was returned after the expiration time given by the endpoint. We make it uniform for easy error handling upon use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello David
Here is the changed to use the DeviceCodeErrorResponseType::ExpiredToken and the Unit Test changes.