Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Package: Upgrade npm on Windows. #3992

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

mook-as
Copy link
Contributor

@mook-as mook-as commented Feb 18, 2023

We seem to be hitting an issue that's already solved in a newer version of npm. Specifically, we sometimes see issues with the npm cache on Windows, which should be npm/cli#3079.

We seem to be hitting an issue that's already solved in a newer version of
npm.

Signed-off-by: Mark Yen <[email protected]>
@mook-as mook-as requested a review from jandubois February 18, 2023 01:57
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wonder if we should do the same thing for the "test signing" step as well.

@jandubois jandubois merged commit ef9fe28 into rancher-sandbox:main Feb 18, 2023
@mook-as mook-as deleted the ci/upgrade-npm branch March 29, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants