This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
introduce the system-upgrade-controller #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes broken ldd with alpine 3.11 - bumps k3s to v1.17.0+k3s.1
|
Supersedes #284 |
|
Maybe this question could be preemptively answered in the docs: Since https://rancher.com/docs/k3s/latest/en/upgrades/automated/ promotes a phased approach preferring master nodes over agent nodes, yet this very PR does not make a distinction, a thought process must have been made over whether the upgrade order is essentially irrelevant or whether master nodes shall be preferred, in which you came to the former conclusion. The question is: Why? (What are the arguments and conclusions? - it might not be easy to infer, for a layman and at the same time be guaranteed to be educational) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/rancher/system-upgrade-controller
also: