add the support for graceful_shutdown_timeout for vSphere nodes #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaqiluo
force-pushed
the
graceful-shutdown
branch
2 times, most recently
from
4e0c5bd to
429dc17
Compare
jiaqiluo
force-pushed
the
graceful-shutdown
branch
from
52c8fb3 to
4eb8655
Compare
|
Shouldn't u add a line under |
jiaqiluo
force-pushed
the
graceful-shutdown
branch
from
4eb8655 to
6f97f5e
Compare
@felipe-colussi, Good catch. PR is updated. |
a-blender
previously requested changes
Oct 5, 2023
HarrisonWAffel
approved these changes
Oct 9, 2023
thatmidwesterncoder
approved these changes
Oct 9, 2023
jiaqiluo
dismissed
a-blender’s stale review
All comments are addressed, and get two approvals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#1222
Problem
We would like to have support for graceful_shutdown_timeout for vSphere nodes in the TF provider.
Solution
Add the support for graceful_shutdown_timeout for vSphere nodes
Testing
Engineering Testing
Manual Testing
This PR has been validated working in the internal vSphere envenomation, including RKE1/RKE2/K3s node-driver vsphere cluster
If the field
graceful_shutdown_timeoutis set in the vsphere_config, when we delete the cluster (terraform destory), the task "initial guest os shutdown" is triggered in vSphere Center Client, which does not happen if we do not set the flag.Automated Testing
Exiting tests are expanded to cover the new field, and that is all we can do for now.
QA Testing Considerations
Provisioning and upgrading of the RKE1/RKE2/K3s node-driver vsphere cluster
Regressions Considerations
Provisioning and upgrading of the RKE1/RKE2/K3s node-driver vsphere cluster