Revert "Remove OpenStack keypair_name references" #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4096070.
This was referenced Sep 25, 2023
… the schema even if there are no references in rancher
thatmidwesterncoder
force-pushed
the
revert_4096070
branch
from
718ad81 to
96fbc6a
Compare
thatmidwesterncoder
added a commit
to thatmidwesterncoder/terraform-provider-rancher2
that referenced
this pull request
Sep 26, 2023
* Revert "Remove OpenStack keypair_name references" This reverts commit 4096070. * Add note to docs that keypair_name for openstack is required to be in the schema even if there are no references in rancher
felipe-colussi
pushed a commit
to felipe-colussi/terraform-provider-rancher2
that referenced
this pull request
Oct 19, 2023
* Revert "Remove OpenStack keypair_name references" This reverts commit 4096070. * Add note to docs that keypair_name for openstack is required to be in the schema even if there are no references in rancher
felipe-colussi
pushed a commit
to felipe-colussi/terraform-provider-rancher2
that referenced
this pull request
Oct 19, 2023
* Revert "Remove OpenStack keypair_name references" This reverts commit 4096070. * Add note to docs that keypair_name for openstack is required to be in the schema even if there are no references in rancher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4096070.
Issue: #1233
Problem
the keypair_name field for openstack was necessary even if there weren't any explicit code references to it in rancher.
Solution
reverting commit 4096070 will fix the issue.