Updated RKE config machine pool schema and structure

[gylli251]

Issue:

#1249

Problem

When you are creating an elemental cluster via terraform the apiversion which rancherv2 cluster uses by default for the machine_config is wrong. You need "elemental.cattle.io/v1beta1".

Solution

Added api_version as an option for machine_config via the schema and structure code. so we can do this:

Testing

I have no idea how to test properly not sure if its needed since these changes are very minor.

Engineering Testing

Manual Testing

Tested the provider myself and have created/destroyed/made changes in place, more than 10 clusters without fault.

Automated Testing

QA Testing Considerations

Regressions Considerations

My first real merge request on github, please advise me if you feel like i can do stuff better!

[gylli251]

There seems to be something wrong with the build... not sure if its my fault or not.

[a-blender]

@gylli251 Nah, appears to be a flaky test. I restarted it.

[a-blender]

Thanks for opening this PR! Looks straightforward to be and since it's an optional field, won't break existing cluster schemas. Lgtm. To answer your question - it will need to be tested by QA, please add a test template to the GH issue outlining test steps for the following cases

1. Provisioning an RKE2 cluster with api_version set.
2. Upgrading the TF version of an existing RKE2 cluster to the next Terraform RC (likely 4.0.0-rc4) to make sure there are no issues / errors.

[mjura]

lgtm

[a-blender]

Can you please add the new field to the docs?

[richardcase]

Looks good to me. Just the comment from @a-blender outstanding:

Can you please add the new field to the docs?

@gylli251 - would you be able to add the field to the docs?

[kkaempf]

ping @gylli251 👆🏻

[gylli251]

I think i added documentation that is sufficient. please let me know if more is needed.

Dismissing this review to unblock PR