Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selection color to the theme config #125

Closed
tranzystorekk opened this issue Jul 6, 2023 · 4 comments
Closed

Add selection color to the theme config #125

tranzystorekk opened this issue Jul 6, 2023 · 4 comments
Labels
wishlist Features wishlist
Milestone

Comments

@tranzystorekk
Copy link
Contributor

Looking at a typical terminal color template like: https://github.com/mbadolato/iTerm2-Color-Schemes/blob/master/README.md#how-to-add-new-template

rio is missing at least a selection field in the [colors] config,

To consider if cursor text color and selection text color are desired as well.

@raphamorim raphamorim added the wishlist Features wishlist label Jul 6, 2023
@raphamorim raphamorim added this to the 0.0.9 milestone Jul 6, 2023
@raphamorim
Copy link
Owner

For this issue would recommend 3 new properties for theme configuration:

selection-foreground = "000000"
selection-background = "000000"
selection-cursor = "000000"

@tranzystorekk
Copy link
Contributor Author

selection-cursor seems unnecessary - typically a user probably won't care enough

@raphamorim
Copy link
Owner

Yeah but is no brainer to implement, so rather keep as personalisation option (it can just inherits the cursor color if is not set)

@raphamorim
Copy link
Owner

raphamorim commented Jul 7, 2023

Hmm, to avoid complexity ignored the selection-cursor as you suggested.

Implemented in 9f64b1a

Screenshot 2023-07-07 at 14 35 00
Screenshot 2023-07-07 at 14 35 08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wishlist Features wishlist
Projects
None yet
Development

No branches or pull requests

2 participants