Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rio 0.0.9 #136624

Merged
merged 2 commits into from
Jul 14, 2023
Merged

rio 0.0.9 #136624

merged 2 commits into from
Jul 14, 2023

Conversation

p-linnane
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
- Created "rio" terminfo.
- Breaking changes for configuration file regarding `Advanced`. The configuration `Advanced` has moved to root level and `disable-render-when-unfocused` renamed to `disable-unfocused-render`.

before

theme = "dracula"

[advanced]
disable-render-when-unfocused = true

now

theme = "dracula"
disable-unfocused-render = true
  • Support to spawn and fork processes, spawn has became default. Spawn increases Rio compability in a broad range, like old MacOS versions (older or equal to Big Sur). However, If you want to use Rio terminal to fork processes instead of spawning processes, enable use-fork in the configuration file:
use-fork = true
  • Introduced RIO_LOG_LEVEL variable usage. (e.g: RIO_LOG_LEVEL=debug rio -e "echo 1")
  • Increased max tabs from 6 to 9.
  • Fix Incorrect cursor position when using multi-byte characters (Ref: #127)
  • Fix bug "black screen with nearly zero interactivity" and new tab hanging.
  • Fix cursor disappearing after resize.
  • Introduction of shell and working_dir in configuration file.
  • Multi window support #97.
  • Corrections on select and scroll experience (it was using wrongly font-bound for line calculation).
  • Add selection color to the theme config (closed #125).
  • Implemented Inverse (fix #92).
  • Proper choose formats that matches with TextureFormat::is_srgb (it fixed the Vulkan driver, related #122).
  • Corcovado: Filter windows crate dependency to only Windows targets (related: #119).
  • Teletypewriter: Fixes for musl as target_env (related: #119).
  • FreeBSD support, implementation by yurivict (Commit, Ref: #115)

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` macos-only Formula depends on macOS labels Jul 14, 2023
@chenrui333
Copy link
Member

Failed to spawn command 'echo 1; exit': No such file or directory (os error 2)

@chenrui333 chenrui333 added test failure CI fails while running the test-do block upstream issue An upstream issue report is needed labels Jul 14, 2023
@alebcay
Copy link
Member

alebcay commented Jul 14, 2023

The issue here is that echo 1; exit is passed as one argument so rio is looking for a binary called echo 1; exit. We could split this into multiple arguments to make the existing test work.

I've replaced the test with one that will hopefully offer a bit more confirmation that the execution is actually happening.

I also tried removing the arm64-only gate on the test to see if it will work now, but will add it back if it still fails on x86_64 (it works for me locally on x86_64).

@raphamorim
Copy link
Contributor

Hey there, sorry about it. The new version doesn't accept string as commands and exit isn't necessary anymore; So you could just run rio --command echo 1

@raphamorim
Copy link
Contributor

raphamorim commented Jul 14, 2023

And the suggestion that @alebcay made works prob even better than it was before since now can check if a file a created after the command execution

@p-linnane p-linnane added ready to merge PR can be merged once CI is green and removed upstream issue An upstream issue report is needed test failure CI fails while running the test-do block labels Jul 14, 2023
@chenrui333
Copy link
Member

And the suggestion that @alebcay made works prob even better than it was before since now can check if a file a created after the command execution

Yeah, we can ship the better test, my issue was mostly confirming about the formula behavior change

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 14, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 14, 2023
Merged via the queue into Homebrew:master with commit cda96c6 Jul 14, 2023
@p-linnane p-linnane deleted the bump-rio-0.0.9 branch July 14, 2023 21:09
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. macos-only Formula depends on macOS outdated PR was locked due to age ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants