Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color not entirely set on vim #88

Closed
matheus1lva opened this issue Jun 7, 2023 · 8 comments
Closed

Background color not entirely set on vim #88

matheus1lva opened this issue Jun 7, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@matheus1lva
Copy link

image
Currently using catpuccin theme and it isnt filling the whole window. I saw we have #52 already, but not sure if it was released yet. Just pinging to track it!

@matheus1lva
Copy link
Author

As also discussed on twitter, the font even though is set to 16, isnt being applied correctly. My conf is:

[style]
font = "SpaceMono Nerd Font"
font-size = 16

@raphamorim
Copy link
Owner

The background color not being set isn't an issue because Rio decoratively has borders, so with a VIM background different than Rio would look like this:

image

The problem is that using custom fonts, it does look often quite small compared to original.

@raphamorim raphamorim added the bug Something isn't working label Jun 7, 2023
@raphamorim
Copy link
Owner

raphamorim commented Jun 7, 2023

This issue is connected to the same behaviour described in #80 (comment)

Rio follow hyper approach and does apply borders:

Screenshot 2023-06-07 at 20 32 23

However Rio terminal should be able to fit the screen at least and as you mentioned font-size should have increased it (doesn't see the case). Added bug label and wishlist.

@raphamorim
Copy link
Owner

Hey @matheus1lva can you test with latest main/canary build?

@OlshaMB
Copy link
Contributor

OlshaMB commented Jun 14, 2023

Fira Code

Снимок экрана 2023-06-14 в 20 40 58

JetBrains Mono

Снимок экрана 2023-06-14 в 20 44 19

@raphamorim
Copy link
Owner

woof, thank you @OlshaMB 🙏

@raphamorim
Copy link
Owner

@OlshaMB @matheus1lva would mind test with latest main?

@raphamorim
Copy link
Owner

I will be closing this issue since not able to reproduce in v0.0.7, please let me know anything and we can reopen in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants