Display glitch when switching the cursor to block

[ehjmx]

At the request of @raphamorim I create this new issue.

I'm on macOS 13.4 and I'm using the canary build

canary-4935590abfe47dab24d53dc1e2268a790b4b94fb

There is display glitch when I switch to block for the cursor.

Cursor underscore looks like this

Cursor as block the block uses two lines
![cursor_as_block](https://github.com/raphamorim/rio/assets/75489369/7928e24b-1717-4879-8e8b-3452c8a91fa0

Version 0.0.61 worked fine. Ffter updating to the canary version and making the necessary modifications to the config file even 0.0.61 did show this glitch after reverting back and using the old config.toml.

Originally posted by @ehjmx in #92 (comment)

[ehjmx]

With the canary-a891a800901db9431e68c32c8f03a300aea06e0e build the cursor glitches are gone and so is the sometimes inconsistent use of the terminal height and width.

For example ls used the full height and width but editors like joe, cmd line mail client aerc and artuin shell history only used the initial space that the terminal had when it was launched.

I was about to create an issue on this once work is done for today.

[raphamorim]

That's great @ehjmx that fixed in the a891a80.

I am also writing tests for the text styles in the renderer, so will avoid breaking this occasionally.

Regarding the terminal height and width is that still happening? Would you mind exemplify a bit more?

[ehjmx]

The issue with the terminal heigh and width is still occassionally occuring, especially when using the 34 inch Monitor with his native 5k resolution.

This is the size of Rio when I open it

Now I change the size

When I now open e.g. joe editor, atuin or aerc only the above initial size is used in the bigger window.
When I use the vim, that comes with macOS or micro editor they use the full bigger window but at the cost of not using the theme that I set for Rio. Could this be related to issue #98 and/or because I set
env-vars = ['SHELL=/opt/local/bin/bash']
in my config file to use bash with Rio while I still have zsh as my default shell?

Using canary canary-2316d6de8782f6eaa94121c508c7798b303ca415 does help on the build in retina display on the MacBookPro M2 2022, macOS 13.4. Tomorrow, Monday, I can check if the whole heigth and width are also used on my 5k Monitor.

[raphamorim]

Thank you @ehjmx for the detailed issue, this problem was happening before right? (Asking because I have been doing a major refactor of the renderer to port to WASM)

[ehjmx]

Yes @raphamorim the issue was before the canary build I mentioned. The refactoring did fix it. However I can only confirm this for the build in Retina display. For the 5k monitor at work I will check tomorrow.

[raphamorim]

Tested in a 5k monitor using v0.0.8 and it does look ok, closing this issue but let me know anything.