Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-wheel: always use auditwheel packages with wildcard support #230

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#137

Starting with the work for that issue, we began relying on support for wildcards in auditwheel repair --exclude in wheel builds:

That feature was first added to auditwheel (by our own @KyleFromNVIDIA !) in release 6.2.0:

This proposes putting a floor of >=6.2.0 on auditwheel, to be sure images here always get a sufficiently new version to support that.

Notes for Reviewers

All seems to be going fine in CI... this PR is inspired by me seeing the use of wildcards fail locally using a slightly older rapidsai/ci-wheel image that had a slightly older auditwheel in it.

I think we'll be happy to have this protection... if some other dependency conflict resulted in auditwheel silently being downgraded here, it could be tough to track backwards from the failures in wheel-building CI to that being the cause.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 22, 2025
@jameslamb jameslamb requested a review from a team as a code owner January 22, 2025 16:18
@jameslamb jameslamb requested review from msarahan and removed request for a team January 22, 2025 16:19
@jameslamb jameslamb merged commit 4b439cc into rapidsai:main Jan 22, 2025
407 checks passed
@jameslamb jameslamb deleted the new-auditwheel branch January 22, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants