Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Remove --expt-relaxed-constexpr from NVCC options #1494

Closed
harrism opened this issue Dec 3, 2024 · 1 comment · Fixed by #1495
Closed

[FEA]: Remove --expt-relaxed-constexpr from NVCC options #1494

harrism opened this issue Dec 3, 2024 · 1 comment · Fixed by #1495
Labels
improvement Improvement / enhancement to an existing function

Comments

@harrism
Copy link
Member

harrism commented Dec 3, 2024 •
edited
Loading

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem you would like to solve.

Projects that use cuProj may prefer not to specify --expt-relaxed-constexpr. This option is no longer needed by cuProj and we should probably remove it to prevent future breakages.

After testing, neither cuSpatial nor cuProj doesn't currently need this flag enabled.

Note that the dependency on cudftestutil injects --expt-relaxed-constexpr onto the command line for cuSpatial tests. Once we remove that dependency it will be gone completely.

Describe any alternatives you have considered

Keep it. We have had at least one user of cuProj who preferred not to have this command line argument be a requirement. It's not likely, but it is possible for this to cause problems. So I think it's better to just remove it.

Additional context

See also No response
@harrism harrism added the improvement Improvement / enhancement to an existing function label Dec 3, 2024
@harrism harrism self-assigned this Dec 3, 2024
@harrism harrism added this to cuSpatial Dec 3, 2024
@github-project-automation github-project-automation bot moved this to Todo in cuSpatial Dec 3, 2024
@harrism harrism mentioned this issue Dec 3, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Dec 4, 2024
@harrism
Remove --expt-relaxed-constexpr NVCC flag (#1495)
628ebcf 
Closes #1494

Removes all (unneeded, currently) instances of `expt-relaxed-constexpr` from cuSpatial and cuProj CMake. 

Also adds linkage of `rmm::rmm_logger_impl` needed after changes to RMM and removal of `cudftestutil` from cuproj benchmarks.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Paul Taylor (https://github.com/trxcllnt)
  - Michael Wang (https://github.com/isVoid)

URL: #1495
@vyasr vyasr mentioned this issue Dec 6, 2024
Open
@harrism harrism removed their assignment Dec 19, 2024
@harrism
Copy link
Member Author

harrism commented Dec 19, 2024

Has been removed for cuProj. Removed it for cuSPatial too but then found it was actually needed, so re-enabled in #1502 .

@harrism harrism closed this as completed Dec 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in cuSpatial Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove --expt-relaxed-constexpr NVCC flag harrism/cuspatial
1 participant
@harrism