Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --expt-relaxed-constexpr NVCC flag #1495

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Remove --expt-relaxed-constexpr NVCC flag #1495

merged 1 commit into from
Dec 4, 2024

Conversation

harrism
Copy link
Member

@harrism harrism commented Dec 3, 2024

Description

Closes #1494

Removes all (unneeded, currently) instances of expt-relaxed-constexpr from cuSpatial and cuProj CMake.

Also adds linkage of rmm::rmm_logger_impl needed after changes to RMM and removal of cudftestutil from cuproj benchmarks.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested review from a team as code owners December 3, 2024 00:14
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added conda Related to conda and conda configuration cmake Related to CMake code or build configuration Python Related to Python code libcuspatial Relates to the cuSpatial C++ library Java Related to Java code labels Dec 3, 2024
@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library libcuproj Relates to the libcuproj C++ library and removed conda Related to conda and conda configuration cmake Related to CMake code or build configuration Python Related to Python code libcuspatial Relates to the cuSpatial C++ library Java Related to Java code labels Dec 3, 2024
@harrism harrism changed the base branch from branch-24.12 to branch-25.02 December 3, 2024 00:50
@harrism harrism requested review from vyasr and removed request for a team and AyodeAwe December 3, 2024 00:51
isVoid
isVoid reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, when I searched this flag in compile_commands.json, it still shows up in cuprojshim compile commands. Is this a flag inherited? Since I didn't see it in cmakelists.

@harrism
Copy link
Member Author

harrism commented Dec 4, 2024 •
edited
Loading

Additionally, when I searched this flag in compile_commands.json, it still shows up in cuprojshim compile commands. Is this a flag inherited? Since I didn't see it in cmakelists.

Thanks. I just checked and initially I saw the cuprojshim relaxed-constexpr too. But I deleted the python build directory and rebuilt (to get rid of compile_commands.json) and it regenerated that file without --expt-relaxed-constexpr in it.

@harrism
Copy link
Member Author

harrism commented Dec 4, 2024

/merge

@rapids-bot rapids-bot bot merged commit 628ebcf into rapidsai:branch-25.02 Dec 4, 2024
76 checks passed
@harrism harrism deleted the fea-remove-cuproj-relaxed-constexpr branch December 4, 2024 03:55
@harrism harrism mentioned this pull request Dec 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@trxcllnt trxcllnt trxcllnt approved these changes

@vyasr vyasr Awaiting requested review from vyasr

Assignees
No one assigned
Labels
cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuproj Relates to the libcuproj C++ library libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Remove --expt-relaxed-constexpr from NVCC options
3 participants
@harrism @trxcllnt @isVoid